Skip to content

[ADD] accounting/l10n_co: adding automatic DIAN enablement process#18026

Closed
masi-odoo wants to merge 1 commit into
19.0from
19.0-masi-dian-enablement-doc-1
Closed

[ADD] accounting/l10n_co: adding automatic DIAN enablement process#18026
masi-odoo wants to merge 1 commit into
19.0from
19.0-masi-dian-enablement-doc-1

Conversation

@masi-odoo

Copy link
Copy Markdown
Contributor
  • Added section on automatic DIAN enablement process for electronic invoicing, with new video reference
  • Eliminated previous video on the topic which is not up to date

@robodoo

robodoo commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@masi-odoo masi-odoo requested a review from afma-odoo May 21, 2026 00:32
@C3POdoo C3POdoo requested a review from a team May 21, 2026 00:36
@afma-odoo afma-odoo removed the request for review from a team May 26, 2026 12:57

@afma-odoo afma-odoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @masi-odoo for your work on this Colombian localization page ☺️
I added some comments/suggestions. If you need more information, just let me know.

Thanks!

Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
@masi-odoo

Copy link
Copy Markdown
Contributor Author

Hey @afma-odoo thanks for reviewing this! I applied the suggestions they were really good.

Please take another look and let me know if there is anything else to be done before continuing!

@afma-odoo afma-odoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @masi-odoo Thank you for the updates ☺️

I misspelled :guilabel: in my review (sorry about that!), so I took the opportunity to add a few suggestions.

I see that the checks failed. Apparently, there's an issue with the commit name:

Image

Could you fix it?
Thanks a lot!

Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
Comment thread content/applications/finance/fiscal_localizations/colombia.rst Outdated
@masi-odoo

Copy link
Copy Markdown
Contributor Author

Hello @afma-odoo everything should be good now, let me know!

@afma-odoo afma-odoo force-pushed the 19.0-masi-dian-enablement-doc-1 branch from abafce2 to 3c7c8b1 Compare May 28, 2026 08:06

@afma-odoo afma-odoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @masi-odoo, thank you for the updates.
I just force-pushed a minor typo that caused the documentation check to fail.

I approve it right away!
Can I r+ ?
Thanks

@masi-odoo

Copy link
Copy Markdown
Contributor Author

Hello @afma-odoo thanks for the typo help!

It can be r+ then, thanks!

@afma-odoo

Copy link
Copy Markdown
Contributor

@masi-odoo Great, thanks!

@robodoo r+

@robodoo

robodoo commented May 29, 2026

Copy link
Copy Markdown
Collaborator

@masi-odoo @afma-odoo because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@masi-odoo

Copy link
Copy Markdown
Contributor Author

Hello @afma-odoo seems there is an action needed by robodoo before merge. I did see something that changed, do you think it will be good to take out the "-" symbols or align them as bullet points?

Maybe this would be the last improvement, but I could need your help on the one 😅

Best!

Screenshot 2026-05-29 at 9 53 01 AM

@afma-odoo afma-odoo force-pushed the 19.0-masi-dian-enablement-doc-1 branch from 3c7c8b1 to a5eaefe Compare June 1, 2026 08:37
@afma-odoo

Copy link
Copy Markdown
Contributor

Hello @masi-odoo! You're right, I fixed the "-" issue and force-pushed the changes ☺️

Can you squash the commits? Thank you!
I'll r+ as soon as it's done ;)

…gestions DIAN enablement

[ADD] accounting/l10n_co: adding automatic DIAN enablement process

Apply suggestion from @masi-odoo

[ADD] accounting/l10n_co: adding automatic DIAN enablement process

- Added section on automatic DIAN enablement process for electronic invoicing, with new video reference
- Eliminated previous video on the topic which is not up to date

Co-Authored-By: afma-odoo <afma@odoo.com>
@masi-odoo masi-odoo force-pushed the 19.0-masi-dian-enablement-doc-1 branch from a5eaefe to 334475c Compare June 5, 2026 17:38
@masi-odoo

Copy link
Copy Markdown
Contributor Author

All set @afma-odoo thanks!

@afma-odoo

Copy link
Copy Markdown
Contributor

Thank you @masi-odoo ☺️

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants